Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add event values to docs #7501

Open
wants to merge 1 commit into
base: dev/feature
Choose a base branch
from
Open

Add event values to docs #7501

wants to merge 1 commit into from

Conversation

Efnilite
Copy link
Member

@Efnilite Efnilite commented Jan 21, 2025 •
edited
Loading

Description

Adds all supported event values of an event to the docs. This includes a check for parent events. Requires SkriptLang/skript-docs#68.

Before
image

After
image

Target Minecraft Versions: any
Requirements: none
Related Issues: none

@Efnilite Efnilite added enhancement Feature request, an issue about something that could be improved, or a PR improving something. documentation Related to Skript's official documentation. require docs update A PR that requires Skript docs to be updated to reflect the related changes. labels Jan 21, 2025
ShaneBeee
ShaneBeee approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@ShaneBeee ShaneBeee left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QUICK.. SHIP IT!

Also, I'm pretty sure there is an issue or 2 you could link to this.

@Efnilite Efnilite mentioned this pull request Jan 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaneBeee ShaneBeee ShaneBeee approved these changes

@sovdeeth sovdeeth Awaiting requested review from sovdeeth

@Moderocky Moderocky Awaiting requested review from Moderocky

@APickledWalrus APickledWalrus Awaiting requested review from APickledWalrus

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
documentation Related to Skript's official documentation. enhancement Feature request, an issue about something that could be improved, or a PR improving something. require docs update A PR that requires Skript docs to be updated to reflect the related changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Efnilite @ShaneBeee