Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enderman Support #7480

Open
wants to merge 2 commits into
base: dev/feature
Choose a base branch
from
Open

Enderman Support #7480

wants to merge 2 commits into from

Conversation

TheAbsolutionism
Copy link
Contributor

@TheAbsolutionism TheAbsolutionism commented Jan 20, 2025 •
edited
Loading

Description

This PR aims to add additional support for endermen:

  • Changing the carrying block data of an enderman
  • Adds a BlockData + ItemType Comparator
    • Allowing if carrying blockdata of {_enderman} is an oak log:
  • Make endermen teleport randomly or towards an entity
  • Check if an enderman has been stared at (Paper)

Target Minecraft Versions: any
Requirements: none
Related Issues: none

@Efnilite Efnilite added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Jan 20, 2025
ShaneBeee
ShaneBeee suggested changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@ShaneBeee ShaneBeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not much to say here, looks good.
Just a few picky things.

src/main/java/ch/njol/skript/expressions/ExprCarryingBlockData.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprCarryingBlockData.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprCarryingBlockData.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/classes/data/DefaultComparators.java Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheeezburga cheeezburga cheeezburga left review comments

@Efnilite Efnilite Awaiting requested review from Efnilite

@ShaneBeee ShaneBeee Awaiting requested review from ShaneBeee

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TheAbsolutionism @ShaneBeee @Efnilite @cheeezburga