-
-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Goat Support #7479
base: dev/feature
Are you sure you want to change the base?
Goat Support #7479
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few ideas about the patterns.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few minor nit picks.
Also, I'm assuming no test for ram, as that'd be hard to do, but is there a reason there is no horn test?
import org.bukkit.entity.LivingEntity; | ||
|
||
@Name("Is Screaming") | ||
@Description("Check if a goat or enderman (Paper) is or is not screaming.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just me being picky, but I feel like this could be shortened.
(Also I feel like the "Paper" part isn't needed, since you have it in required plugins)
@Description("Check if a goat or enderman (Paper) is or is not screaming.") | |
@Description("Check whether a goat or enderman is screaming.") |
import org.jetbrains.annotations.Nullable; | ||
|
||
@Name("Make Entity Scream") | ||
@Description("Make a goat or enderman (Paper) start or stop screaming.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above, I dont feel like the "Paper" part is needed here.
@Description("Make a goat or enderman (Paper) start or stop screaming.") | |
@Description("Make a goat or enderman start or stop screaming.") |
Description
This PR aims to add additional support for Goats:
Changing the horns of a goat takes a tick thus leading to no test.
Target Minecraft Versions: any
Requirements: none
Related Issues: none