Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goat Support #7479

Open
wants to merge 3 commits into
base: dev/feature
Choose a base branch
from

Conversation

TheAbsolutionism
Copy link
Contributor

Description

This PR aims to add additional support for Goats:

  • Change which horns a goat has and a condition to match
  • Make goats and endermen (Paper) scream and a condition to match
  • Make goats ram an entity (Paper)

Changing the horns of a goat takes a tick thus leading to no test.


Target Minecraft Versions: any
Requirements: none
Related Issues: none

Copy link
Contributor

@ShaneBeee ShaneBeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few ideas about the patterns.

src/main/java/ch/njol/skript/conditions/CondGoatHorns.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/effects/EffGoatHorns.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/effects/EffScreaming.java Outdated Show resolved Hide resolved
@Efnilite Efnilite added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Jan 20, 2025
Copy link
Contributor

@ShaneBeee ShaneBeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few minor nit picks.
Also, I'm assuming no test for ram, as that'd be hard to do, but is there a reason there is no horn test?

import org.bukkit.entity.LivingEntity;

@Name("Is Screaming")
@Description("Check if a goat or enderman (Paper) is or is not screaming.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just me being picky, but I feel like this could be shortened.
(Also I feel like the "Paper" part isn't needed, since you have it in required plugins)

Suggested change
@Description("Check if a goat or enderman (Paper) is or is not screaming.")
@Description("Check whether a goat or enderman is screaming.")

import org.jetbrains.annotations.Nullable;

@Name("Make Entity Scream")
@Description("Make a goat or enderman (Paper) start or stop screaming.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above, I dont feel like the "Paper" part is needed here.

Suggested change
@Description("Make a goat or enderman (Paper) start or stop screaming.")
@Description("Make a goat or enderman start or stop screaming.")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants