EvtRealTime

[Absolutionism]

Description

This PR aims to add an event that is called when the local time of the system reaches the provided time(s)
Allowing users to make real time events for their server.

---

Target Minecraft Versions: any
Requirements: none
Related Issues: #3378

[Efnilite]

perhaps some tests may be warranted

[Burbulinis]

What do you think of the syntax pattern at %time% [in] real time instead of the current on real time (of|at) %time%? The latter doesn't sound grammatically correct or natural.

[Moderocky]

Yes

[Absolutionism]

What do you think of the syntax pattern at %time% [in] real time instead of the current on real time (of|at) %time%? The latter doesn't sound grammatically correct or natural.

Well, imo, it would make it look silly if users provided multiple times. on 3pm, 6pm, 9pm in real time:
But it's whatever the mass majority chooses on.

[Burbulinis]

What do you think of the syntax pattern at %time% [in] real time instead of the current on real time (of|at) %time%? The latter doesn't sound grammatically correct or natural.

Well, imo, it would make it look silly if users provided multiple times. on 3pm, 6pm, 9pm in real time: But it's whatever the mass majority chooses on.

It won’t be on …, but at … like the current EvtWorldTime (or however the class is named). And personally, it sounds fine

[Absolutionism]

It won’t be on …, but at … like the current EvtWorldTime (or however the class is named)

Right, but regardless, to me it would still look silly. at 3pm, 6pm, 9pm in real time:

[Absolutionism]

Again, it's whatever the majority chooses. Can't fight that

[sovdeeth]

It won’t be on …, but at … like the current EvtWorldTime (or however the class is named)

Right, but regardless, to me it would still look silly. at 3pm, 6pm, 9pm in real time:

seems fine to me, since proper use would entail using and
at 3 pm, 6 pm, and 9 pm in real time

on real time of 3 pm, 6 pm, and 9 pm makes a lot less sense to me

[Absolutionism]

Well, that seems to be the majority then. I will make change

[sovdeeth]

The more I'm thinking about this, the less I understand why Time needs changes at all. EvtRealTime doesn't use Time after getting its hour/minute values, so why does Time need to store AM/PM? Can't it just convert everything to 24hr time internally, like it already did?
(plus 6pm will return 6 for getHour now, which means the epected calendar date will be 6am, not pm)

[Absolutionism]

why does Time need to store AM/PM?

Just through each iteration of requested changes, the usage of it was lost. As I had utilized it beforehand.

(plus 6pm will return 6 for getHour now, which means the epected calendar date will be 6am, not pm)

I’m pretty sure it works as intended, I only tested 2 times (12:10 am and 3:15pm)
Which returned the correct amount of time.
Since in the constructor call, the time inputted is subtracting “HOUR_ZERO” but I can check more times including 6am and 6pm

[sovdeeth]

why does Time need to store AM/PM?

Just through each iteration of requested changes, the usage of it was lost. As I had utilized it beforehand.

(plus 6pm will return 6 for getHour now, which means the epected calendar date will be 6am, not pm)

I’m pretty sure it works as intended, I only tested 2 times (12:10 am and 3:15pm) Which returned the correct amount of time. Since in the constructor call, the time inputted is subtracting “HOUR_ZERO” but I can check more times including 6am and 6pm

Ah right it works if you add 12 hours prior to construction, which is done in the parser, so it's 12 hours worth of seconds stored (which rolls back around to what's the point of timeformat but you already addresssed that)

[Absolutionism]

which rolls back around to what's the point of timeformat

Just to check, but do you want me to remove it?

[sovdeeth]

which rolls back around to what's the point of timeformat

Just to check, but do you want me to remove it?

Yeah it doesn't need to exist so no need to add it

[sovdeeth]

just a few last things

[sovdeeth]

looking good