Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ss phase 1 into 61.1 release branch #289

Merged
merged 266 commits into from
May 28, 2024
Merged

Ss phase 1 into 61.1 release branch #289

merged 266 commits into from
May 28, 2024

Conversation

JessiePotter1
Copy link

No description provided.

hnandra and others added 30 commits April 22, 2024 18:00
@hnandra
Fixed CSHTML render path
ad2ff1a
@gcomptonedu
Added test and updated cshtml location
caf1d28
@hnandra
Finalised HowToBecome changes for JobProfileService
7469f31
@hnandra
Added RealStory mapping
1a4d49a
@hnandra
Fixed null check to the views
f129043
@hnandra
Fixed logic for adding the howToBecome segment
61c1992
@JamesPrior-07
Changes to Job profiles to pull Related careers data from GraphQL
b228531
@JamesPrior-07
Changes to replace related careers segment data
ffc3c05
@JamesPrior-07
Updated GraphQL calls to use Redis expiry
387c141
@JamesPrior-07
Updated Unit/Integration tests
bb83f41
@gcomptonedu
Updated config settings and added filter.
6dd5141
@hnandra
Added unit tests
b862c31
@hnandra
Added null checks to the custom resolvers
6cba49e
@gcomptonedu
Added config for Cms__TokenEndPointUrl
a33311e
@hnandra
Added null check to CommonRoutes
7a04ed3
@JamesPrior-07
Added ContentMode to redis call
349e67a
@gcomptonedu @hnandra
Updated config settings and added filter.
004e4f1
@gcomptonedu @hnandra
Added config for Cms__TokenEndPointUrl
8020887
@hnandra
Fixed unit tests
3f72fbd
@hnandra
Update JobProfileService.cs
eb34ac6
Resovle 500
b81b256
Resolve 500 error
fc158b9
Fix 500 error and currency symbol
e810df9
@JamesPrior-07
Added Related Careers Unit tests
63594d4
Remove content from cosmos DB and validation
18f0ea8
Comments out the failed unit tests
c3a8ba4
@ZhaomingLu2009
Merge pull request #268 from SkillsFundingAgency/feature/AD-175673
0542bba 
Feature/ad 175673
@JamesPrior-07
Updated Arm templates with env variables
f330fec
@hnandra
Merge branch 'SS-Phase-1' into AD-175352
2515a5a
@hnandra
Update JobProfileService.cs
1f77986
Zhaoming LU and others added 25 commits May 21, 2024 12:17
remove white space
d5a5744
Resovle sonar cloud issues
9db32a8
@hnandra
Updated health items
565bef5
@hnandra
Fixed automapper profile
0bc1461
@gcomptonedu
Change the cache key being used.
e077d2d
Add unit tests
f20a21a
@gcomptonedu
Merge pull request #287 from SkillsFundingAgency/feature/AD-175355
2ac3e10 
Change the cache key being used.
add more unit tests
a95e3b8
@ZhaomingLu2009
Merge branch 'SS-Phase-1' into feature/AD-175689
a063064
Add more unit tests
04d7518
Merge branch 'feature/AD-175689' of https://github.com/SkillsFundingA…
143382b 
…gency/dfc-app-jobprofiles into feature/AD-175689
@ZhaomingLu2009
Merge pull request #285 from SkillsFundingAgency/feature/AD-175689
dd6cc79 
Feature/ad 175689
@hnandra
Added breadcrumb to JobProfileModel mapping
a6b3102
@hnandra
Merge branch 'SS-Phase-1' into AD-175693
a782272
@hnandra
Update ProfileControllerTests.cs
a8ae87b
@hnandra
Fixed merge conflicts
0dc0488
@hnandra
Added back deleted unit tests
fca1be0
@hnandra
Merge pull request #278 from SkillsFundingAgency/AD-175693
6182df6 
AD-175693: Job Profiles - Display Each Segment
@ZhaomingLu2009
Update WebJobsExtensionStartup.cs
15bb93a
Make function apps back
d6be9db
@gcomptonedu
Ordering of lars codes
11bfe5a
Fix bug 181316
190b50e
@gcomptonedu
Merge pull request #288 from SkillsFundingAgency/feature/AD-181315
445ab5a 
Feature/ad 181315 - ordering of lars codes
@hnandra
Fixed SocialProofVideo logic
dbfc2e4
@gcomptonedu
Updated cron time
1cb96de
@JessiePotter1 JessiePotter1 requested a review from a team as a code owner May 24, 2024 10:09
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 24, 2024

Quality Gate Passed Quality Gate passed

Issues
125 New issues
0 Accepted issues

Measures
0 Security Hotspots
74.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 24, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
74.2% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

gcomptonedu
gcomptonedu approved these changes May 24, 2024
View reviewed changes
Copy link

@gcomptonedu gcomptonedu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

@JessiePotter1 JessiePotter1 merged commit 756c9f6 into release/live-service/61.1 May 28, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gcomptonedu gcomptonedu gcomptonedu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@JessiePotter1 @gcomptonedu @hnandra @JamesPrior-07 @ZhaomingLu2009 @amjones99