Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ps release 6.10 #1478

Merged
merged 20 commits into from
Jun 12, 2024
Merged

Ps release 6.10 #1478

merged 20 commits into from
Jun 12, 2024

Conversation

ShakilUmar
Copy link
Contributor

No description provided.

dinathain
dinathain previously approved these changes Jun 6, 2024
tom-gough and others added 2 commits June 7, 2024 12:12
…ner api with no payments status, and when no apprenticeship is returned from the inner api (because it pre dates das-apprenticeships). In both these cases the payment status should be NOT frozen, PaymentsFrozen=false
…ease-fix

Handle both scenarios where an apprenticeship is returned from the inner api with no payments status, and when no apprenticeship is returned from the inner api (because it pre dates das-apprenticeships). In both these cases the payment status should be NOT frozen, PaymentsFrozen=false
Copy link

sonarcloud bot commented Jun 10, 2024

Quality Gate Failed Quality Gate failed for 'das-apim-endpoints-Apprenticeships'

Failed conditions
46.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Jun 10, 2024

Quality Gate Passed Quality Gate passed for 'das-apim-endpoints-Approvals'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
66.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@dinathain
Copy link
Contributor

Spoken with @ratheeshri1984 regarding pipeline failure on das-apim-endpoints-shared since the issue is in the ProviderFeedback outer API. They confirmed that this will be resolved shortly.

I have approved since this doesn't impact the ability for us to deploy these changes safely.

@dinathain dinathain merged commit 988588d into master Jun 12, 2024
53 of 55 checks passed
@dinathain dinathain deleted the PS-Release-6.10 branch June 12, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants