Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flp release 6.9 - Change of Start Date #1455

Merged
merged 48 commits into from
Jun 3, 2024
Merged

Flp release 6.9 - Change of Start Date #1455

merged 48 commits into from
Jun 3, 2024

Conversation

ShakilUmar
Copy link
Contributor

No description provided.

Pauljgraham and others added 30 commits January 31, 2024 15:47
# Conflicts:
#	src/Apprenticeships/SFA.DAS.Apprenticeships.UnitTests/Application/Apprenticeship/WhenGettingApprenticeshipStartDate.cs
#	src/Apprenticeships/SFA.DAS.Apprenticeships/Application/Apprenticeship/GetApprenticeshipStartDateQuery.cs
#	src/Apprenticeships/SFA.DAS.Apprenticeships/Responses/ApprenticeshipStartDateResponse.cs
#	src/Shared/SFA.DAS.SharedOuterApi/InnerApi/Responses/Apprenticeships/GetApprenticeshipStartDateResponse.cs
…tandardInfo (e.g. if there is a standard version with no effective to date it is open and so any date after the effective from is valid
…sFundingAgency/das-apim-endpoints into FLP-606-validate-standard-versions
…andard-versions

Flp 606 Add standards and standard versions info to start date query to enable validation
…or conditional display of payments warning for hard closed academic year
Copy link

sonarcloud bot commented May 7, 2024

Quality Gate Passed Quality Gate passed for 'das-apim-endpoints-Funding'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented May 14, 2024

Quality Gate Passed Quality Gate passed for 'das-apim-endpoints-Approvals'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
49.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented May 23, 2024

Quality Gate Failed Quality Gate failed for 'das-apim-endpoints-Apprenticeships'

Failed conditions
53.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@ShakilUmar ShakilUmar merged commit ea13689 into master Jun 3, 2024
53 of 56 checks passed
@ShakilUmar ShakilUmar deleted the FLP-Release-6.9 branch June 3, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants