Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APPMAN-876 call pso inner api from employer accounts to fetch the data #1447

Open
wants to merge 94 commits into
base: APPMAN-790-edu-org-inner-api
Choose a base branch
from

Conversation

Pauljgraham
Copy link
Contributor

No description provided.

Copy link
Contributor

@cofaulco cofaulco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 question

Copy link

sonarcloud bot commented Apr 30, 2024

Quality Gate Failed Quality Gate failed for 'das-apim-endpoints-Funding'

Failed conditions
14.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Apr 30, 2024

Quality Gate Failed Quality Gate failed for 'das-apim-endpoints-EmployerAccounts'

Failed conditions
77.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

cofaulco
cofaulco previously approved these changes Apr 30, 2024
Copy link

sonarcloud bot commented Jun 11, 2024

Quality Gate Passed Quality Gate passed for 'das-apim-endpoints-LevyTransferMatching'

Issues
9 New issues
0 Accepted issues

Measures
0 Security Hotspots
14.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Jun 11, 2024

Quality Gate Failed Quality Gate failed for 'das-apim-endpoints-EmployerAccounts'

Failed conditions
77.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

…port-of-education-data

Appman-790 start import of education data
@Pauljgraham Pauljgraham changed the base branch from master to APPMAN-790-edu-org-inner-api June 12, 2024 07:57
SijiOdun and others added 12 commits June 12, 2024 11:40
…plications-Draft

FAI-1204-Migrate-Applications-Draft
…artup-fix

add back startup to providerFeedback
)

* CSP-1379: Get employer relationships outer API endpoint.

* CSP-1379: Upgrade transitive packages.

* CSP-1379: Upgrade transitive packages.

* CSP-1379: Unit test to cover construction of get employer relationships url.

* CSP-1379: Rework management endpoints to work through a restease client within the EmployerPR API.

* CSP-1379: Removed unused GetEmployerRelationshipsRequest object.

* CSP-1379: Update operations namespace.

* CSP-1379: Revert operations change.

* CSP-1379: Update Operations reference.
APPMAN-790 EmployerAccounts calling education orgs API (manual merge)
@Pauljgraham Pauljgraham requested a review from a team as a code owner June 13, 2024 14:19
MarkFCain and others added 5 commits June 13, 2024 15:44
* CSP-1390 - Added call to pr api to get AccountProviderLegalEntities

* CSP-1390 - Added missing registrations, corrected request url and updated logic in the request to match new url

* CSP-1390 - Fixed issues caused by master merge

* CSP-1390 - Minor refactor to clearsonar warnings

* CSP-1390 - Modified logging to clear sonar security issue

* CSP-1390 - Minor refactors to fix issues caused by shared outer api changes

* CSP-1390 - Additional refactoring to fix issues caused by shared project changes

* CSP-1390 - Fixed unit test broken by shared package changes

* CSP-1390 - Simplified url construction, fixed issue in other services where previous changes changed the operations passed to the request, removed duplicate operations definitions

* CSP-1390 - Minor refactor to resolve build errors

* CSP-1390 - Fixed build failure caused by removing duplicate Operations definitions

* CSP-1390 - Removed redunant prop initialisation

* CSP-1390 - Manually referencing newer versions of transitive dperecated packages to clear build warnings

* CSP-1390 - Fixed issues caused by merge conflicts
…ion-of-my-transfer-pledges

APPMAN-1017 pagination of my transfer pledges
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet