This repository has been archived by the owner on Sep 17, 2022. It is now read-only.
Test fix for atoms subsystem #98
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Urumasi
reviewed
Jul 14, 2021
| for(var/I in late_loaders) | ||
| var/atom/A = I | ||
| A.LateInitialize() | ||
| for(var/atom/A in late_loaders) |
There was a problem hiding this comment.
Suggested change
| for(var/atom/A in late_loaders) | |
| for(var/atom/A as anything in late_loaders) |
This is faster and accomplishes the same thing, we already expect atoms to be here
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Should at least prevent atoms subsystem from breaking too hard. Might fix stuck sparks completely if we're lucky.
Why It's Good For The Game
Bugfix good
Changelog
🆑
fix: Fix stuck sparks, invisible plumbing ports, and possibly more!
/:cl: