Skip to content
This repository has been archived by the owner on Sep 17, 2022. It is now read-only.

Implemented blue pylon tank refill interaction #76

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

ZombieNub
Copy link
Contributor

@ZombieNub ZombieNub commented Jun 11, 2021

About The Pull Request

This allows the blue slimic pylon to behave similarly to the yellow slimic pylon by refilling tanks it has been hit by.

Why It's Good For The Game

The blue slimic pylon broke the need for an atmos system, but the current nerf renders it basically useless outside of cooling down the station after a fire. This buff allows the slimic pylon to once again have an atmos role by allowing an instant tank refill that can be used to manually replace the air in the atmos system, or simply allow miners a more convenient refill.

Changelog

🆑
tweak: Buffed blue pylon to allow tank refill
/:cl:

@KubeRoot
Copy link
Contributor

KubeRoot commented Jun 11, 2021

Multi-line edits and additions should use //Singulostation begin and //Singulostation end comments wrapping the change

edit: Also, the changelog says canister refill; this should be tanks instead, correct?

@ZombieNub
Copy link
Contributor Author

edit: Also, the changelog says canister refill; this should be tanks instead, correct?

Yes, my bad.

@KubeRoot
Copy link
Contributor

KubeRoot commented Jun 11, 2021

Err, I think the begin comment should still have the change in it

edit: Oh, you kept the edit comment.
Okay, to clarify: remove the Singulostation edit comment, and move the description to the Singulostation begin comment.

Actually, fuck me, this is all in the singulostation folder, I think you don't need to have any comments describing the change. Sorry for the confusion, best ask Malt on discord.

@ZombieNub
Copy link
Contributor Author

I made the edits before you edited your comment. Oh well, good practice at least.

@Laboredih123
Copy link

imma have fun with this

@github-actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being closed by a maintainer if it is not updated or reviews are not addressed. If your PR is closed as stale, feel free to open a new one after dealing with the issues. This may also be an indication that the maintainers do not have interest in this change, you can try to convince them otherwise, or persist in the doomed world you have created.

…/_structures.dm


Statement rewrite because Urumasi is better at writing than me.

Co-authored-by: Urumasi <[email protected]>
@Urumasi
Copy link
Contributor

Urumasi commented Jun 28, 2021

When using a tank with other gases in it (like a plasma tank) it doesn't replace the air with oxygen as hinted by the text, but just adds 12 atmospheres of oxygen. Is this the intended functionality?

Results of analysis of the plasma tank.
Moles: 43.67 mol
Volume: 70 L
Pressure: 1519.87 kPa
Temperature: 20 °C (293.15 K)
Oxygen: 80 % (34.94 mol)
Plasma: 20 % (8.73 mol)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants