Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove smart quotes from file_event_win_iphlpapi_dll_sideloading.yml #4856

Merged
merged 1 commit into from
May 15, 2024

Conversation

jeremyhagan
Copy link
Contributor

@jeremyhagan jeremyhagan commented May 15, 2024

Summary of the Pull Request

Removed smart quotes from title of rule which were causing the payload to bomb out when sending to Microsoft Sentinel as a detection rule template

Changelog

fix: Malicious DLL File Dropped in the Teams or OneDrive Folder - Remove smart quotes

Example Log Event

Fixed Issues

SigmaHQ Rule Creation Conventions

  • If your PR adds new rules, please consider following and applying these conventions

@github-actions github-actions bot added Rules Windows Pull request add/update windows related rules labels May 15, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @jeremyhagan 👋

It looks like this is your first pull request on the Sigma rules repository!

Please make sure to read the SigmaHQ conventions document to make sure your contribution is adhering to best practices and has all the necessary elements in place for a successful approval.

Thanks again, and welcome to the Sigma community! 😃

@frack113 frack113 merged commit f334abf into SigmaHQ:master May 15, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Rules Windows Pull request add/update windows related rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants