Skip to content

Fix for atomic issue #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix for atomic issue #94

wants to merge 1 commit into from

Conversation

adampetro
Copy link
Contributor

In the CachedInternedStringId we need to read the context and pointer in a single atomic operation instead of in multiple. This is possible in a 32 bit architecture through AtomicU64. For 64 bit architecture, I went with a Mutex instead

Fixes #91

@adampetro adampetro requested a review from saulecabrera June 17, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saulecabrera saulecabrera saulecabrera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sporadic test failures due to out of bounds errors
2 participants
@adampetro @saulecabrera