-
Notifications
You must be signed in to change notification settings - Fork 28
Add release
workflow
#40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
References
- https://github.com/changesets/changesets
- https://github.com/changesets/action
- https://github.com/Shopify/ui-extensions/blob/unstable/.github/workflows/deploy.yml
- https://github.com/Shopify/admin-ui-foundations/blob/main/.github/workflows/generate-version-packages.yml
- https://github.com/Shopify/extensibility/blob/main/.github/workflows/release.yml
|
||
- name: Create Release Pull Request or Publish to npm | ||
id: changesets | ||
uses: changesets/action@v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This action for Changesets creates a pull request with all of the package versions updated and changelogs updated and when there are new changesets on your configured baseBranch, the PR will be updated. When you're ready, you can merge the pull request and you can either publish the packages to npm manually or setup the action to do it for you. - https://github.com/changesets/action?tab=readme-ov-file
@billfienberg I wouldn't ship this just yet as if folks need to ship a hotfix they will be used to the current release approach. This could slow down important fixes so we should ship this after summit IMO. |
That makes sense to me. |
TLDR
Add
release
workflow so we can publish versions via changesetsReferences