Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove comment from homebrew installation snippet #5489

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Domogo
Copy link

@Domogo Domogo commented Mar 5, 2025

  • removed comment from .sh file
  • added macOS label to tab

It's annoying to copy a code snippet that gives you an "invalid command" error. Proposing this as an alternative

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

It's annoying to copy a code snippet that gives you an "invalid command" error. Proposing this as an alternative
@Domogo Domogo requested review from a team as code owners March 5, 2025 11:47
@@ -43,7 +43,7 @@ const data: LandingTemplateSchema = {
language: 'bash',
},
{
title: 'homebrew',
title: 'homebrew (macOS)',
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: 'homebrew (macOS)',
title: 'homebrew',

Can also not add this, it makes the tab title a bit long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant