Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve loading bar resizes #5472

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

isaacroldan
Copy link
Contributor

@isaacroldan isaacroldan commented Feb 27, 2025

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

How to test your changes?

Run pnpm shopify kitchen-sink:async and resize your terminal.

I've temporarily disabled other items in the kitchen-sink to simplify the testing.

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor Author

/snapit

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

🫰✨ Thanks @isaacroldan! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

pnpm i -g @shopify/[email protected]

Tip

If you get an ETARGET error, install it with NPM and the flag --@shopify:registry=https://registry.npmjs.org

Caution

After installing, validate the version by running just shopify in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
76.12% (+0.16% 🔼)
9182/12062
🟡 Branches
71.11% (-0.02% 🔻)
4493/6318
🟡 Functions
75.7% (+0.18% 🔼)
2393/3161
🟡 Lines
76.66% (+0.14% 🔼)
8673/11313
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / app-event-watcher.ts
96.39% (-1.2% 🔻)
88.57% (-2.86% 🔻)
95.45% 100%
🟢
... / ConcurrentOutput.tsx
98.36% (-1.64% 🔻)
88% (-4% 🔻)
100%
98.33% (-1.67% 🔻)
🟢
... / TextAnimation.tsx
96.55% (-3.45% 🔻)
50%
88.89% (-11.11% 🔻)
96.55% (-3.45% 🔻)

Test suite run success

2084 tests passing in 924 suites.

Report generated by 🧪jest coverage report action from 9c9a6cd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant