Disable local payments extension #5469
Draft
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casoetan
reviewed
Mar 3, 2025
Comment on lines
+79
to
+81
| if (isTruthy(process.env.SHOPIFY_CLI_USE_LOCAL_PAYMENTS_SPEC)) { | ||
| moduleSpecs.push(paymentExtensionSpec as unknown as ExtensionSpecification) | ||
| } |
There was a problem hiding this comment.
When this ships, only new versions of the CLI will require setting SHOPIFY_CLI_USE_LOCAL_PAYMENTS_SPEC this value to false for them to use the previous experience, right? Where and how do we communicate these changes to partners?
There was a problem hiding this comment.
This is just a failsafe in case everything goes wrong with contracts.
- Old versions of the CLI will use both the local Schema and the Contract for validations.
- New versions of the CLI will only use the contract for validation, this flag allows us to eventually re-enable local schemas in case we need to revert contract changes.
Ideally we never use this and in the next version of the CLI this is removed (along with all the payments code in the CLI)
casoetan
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #0000
WHAT is this pull request doing?
How to test your changes?
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist