fix: ignore zod errors for json schema validations #5461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Show files with reduced coverage 🔻
Test suite run success2084 tests passing in 924 suites. Report generated by 🧪jest coverage report action from 130aebc |
toddjeff
reviewed
Feb 26, 2025
| @@ -56,7 +56,7 @@ export async function unifiedConfigurationParserFactory( | |||
| errorSet.add(key) | |||
| return true | |||
| }) | |||
| if (zodParse.state !== 'ok' || errors.length > 0) { | |||
| if (jsonSchemaParse.state !== 'ok') { | |||
There was a problem hiding this comment.
shouldn't this just look at the length of errors? In this case if zodParse had errors, but jsonSchemaParse didn't it wouldn't return the error state?
There was a problem hiding this comment.
We technically should not be using zodParse for json schema. I would like to remove it from this file, but I feel I may be missing some edge cases and reasoning behind why it's still used here.
toddjeff
reviewed
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
JSON schema extension contracts validations were being ignored. Custom CLI validations were still being used to validate json-schemas from the server. As we move to the CLI being a dumb client, respecting the server schema file will help make moving to the new world faster
WHAT is this pull request doing?
Switching from zod validations to json-schema validations for extensions with json-schemas
How to test your changes?
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist