Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip #5457

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

wip #5457

wants to merge 3 commits into from

Conversation

EvilGenius13
Copy link
Contributor

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@EvilGenius13 EvilGenius13 force-pushed the windows-theme-check-prototype branch from bbbc468 to bac5422 Compare February 24, 2025 19:24
@EvilGenius13 EvilGenius13 force-pushed the windows-theme-check-prototype branch from bac5422 to 663aae1 Compare February 24, 2025 20:17
@EvilGenius13 EvilGenius13 reopened this Feb 24, 2025
Copy link
Contributor

github-actions bot commented Feb 24, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.98% (+0.01% 🔼)
9179/12081
🟡 Branches
71.12% (-0.01% 🔻)
4492/6316
🟡 Functions
75.54% (+0.02% 🔼)
2393/3168
🟡 Lines
76.54% (+0.02% 🔼)
8670/11327
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / app-event-watcher.ts
96.39% (-1.2% 🔻)
88.57% (-2.86% 🔻)
95.45% 100%
🟢
... / ConcurrentOutput.tsx
98.36% (-1.64% 🔻)
88% (-4% 🔻)
100%
98.33% (-1.67% 🔻)

Test suite run success

2084 tests passing in 924 suites.

Report generated by 🧪jest coverage report action from 21e7cdf

@EvilGenius13
Copy link
Contributor Author

/snapit

Copy link
Contributor

🫰✨ Thanks @EvilGenius13! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

pnpm i -g @shopify/[email protected]

Tip

If you get an ETARGET error, install it with NPM and the flag --@shopify:registry=https://registry.npmjs.org

Caution

After installing, validate the version by running just shopify in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

@EvilGenius13
Copy link
Contributor Author

/snapit

Copy link
Contributor

🫰✨ Thanks @EvilGenius13! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

pnpm i -g @shopify/[email protected]

Tip

If you get an ETARGET error, install it with NPM and the flag --@shopify:registry=https://registry.npmjs.org

Caution

After installing, validate the version by running just shopify in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

@EvilGenius13
Copy link
Contributor Author

/snapit

Copy link
Contributor

🫰✨ Thanks @EvilGenius13! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

pnpm i -g @shopify/[email protected]

Tip

If you get an ETARGET error, install it with NPM and the flag --@shopify:registry=https://registry.npmjs.org

Caution

After installing, validate the version by running just shopify in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

@EvilGenius13 EvilGenius13 force-pushed the windows-theme-check-prototype branch 2 times, most recently from 4c0aae2 to fb91442 Compare February 27, 2025 14:51
@EvilGenius13
Copy link
Contributor Author

/snapit

Copy link
Contributor

🫰✨ Thanks @EvilGenius13! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

pnpm i -g @shopify/[email protected]

Tip

If you get an ETARGET error, install it with NPM and the flag --@shopify:registry=https://registry.npmjs.org

Caution

After installing, validate the version by running just shopify in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

@EvilGenius13 EvilGenius13 force-pushed the windows-theme-check-prototype branch from 3d5b107 to f7c7c00 Compare February 27, 2025 19:07
@EvilGenius13
Copy link
Contributor Author

/snapit

Copy link
Contributor

🫰✨ Thanks @EvilGenius13! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

pnpm i -g @shopify/[email protected]

Tip

If you get an ETARGET error, install it with NPM and the flag --@shopify:registry=https://registry.npmjs.org

Caution

After installing, validate the version by running just shopify in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant