Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a command to specify the extension preview port #5426

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

0zd0
Copy link
Contributor

@0zd0 0zd0 commented Feb 19, 2025

WHY are these changes introduced?

Fixes #5424

Unable to configure Nginx config for random port of extension preview server when developing in Devcontainer

WHAT is this pull request doing?

Adds the --previewable-extension-port flag to the dev command by example --theme-app-extension-port

How to test your changes?

  1. Create an App Remix
  2. Create at least one extension
  3. Run the application via dev command with --previewable-extension-port 8021
  4. Verify that extension preview is available on port 8021 (possibly proxied by nginx).

image

Post-release steps

You will need to edit the documentation about dev flags

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@0zd0 0zd0 requested a review from a team as a code owner February 19, 2025 01:04
@0zd0
Copy link
Contributor Author

0zd0 commented Feb 19, 2025

I have signed the CLA!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No route matches URL "/extensions/dev-console"
1 participant