Prototype CLI passing operations to deploy for discount functions #5384
+32
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Show files with reduced coverage 🔻
Test suite run success2045 tests passing in 913 suites. Report generated by 🧪jest coverage report action from 1c9d8f2 |
saga-dasgupta
force-pushed
the
functions_discoun_multiclass_support
branch
from
1c9d8f2 to
38bc170
Compare
saga-dasgupta
force-pushed
the
functions_discoun_multiclass_support
branch
from
38bc170 to
809b179
Compare
saga-dasgupta
force-pushed
the
functions_discoun_multiclass_support
branch
from
82b88a2 to
9defcd8
Compare
saga-dasgupta
force-pushed
the
functions_discoun_multiclass_support
branch
from
5999156 to
5846d86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
To allow us to obtain values for operations passed by partners for a discount function and pass it to core to persist on the ShopifyVM::Domain::Functions model.
WHAT is this pull request doing?
Making
operationspart of the functions deploy config for app deploys.How to test your changes?
Create a discount function that uses the new discounts api and checkout this core branch commit in your spin instance. The TOML file should look like the following:
Check partners internal to find the app and the function config with operations present under targets after deployment.
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist