-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signing templates #618
base: main
Are you sure you want to change the base?
Signing templates #618
Conversation
Feat/template
@rockingrohit9639 yesterday we discussed the last pending point. Please find the information below on what needs to be implemented: Limits
User safetyTo ensure user safety and prevent abuse from admins we have to make it so that once a template has been used once(signed or unsigned), we should not allow to change the file. To do that please disable the file field in that case with the following message: |
… signing-templates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Custody agreements limits should be 0 for free tier and tier_1. Only tier_2(team) can have them
- Adding a new agreement seems to check
maxCustodyAgreements
instead ofmaxActive...
. I could add a 6th one:
- When custody is assigned with agreement that doesnt require signature, the link to the agreement should still be in the email.
- Editing a file from an agreement that is used works good, but i dont see the message:
This custody agreement has already been used and signed and it's file cannot be changed anymore. If your agreement document has changed, please create a new custody agreement with your new document.
…r free and tier_1
Comments/Feedback: Template upload area Please add a column to show if the agreement is 'Ask for signature' or 'View only' (You can use the same 'pill' - as we have used on the 'default' column. Asset Index Advanced Asset Index Asset Page Receipts page Receipt explorer/modal
Signature collection screen Please make the signature font look signature-ish (https://github.com/documenso/documenso/tree/main/apps/remix/public/fonts) use Caveat. View Only Agreement Please add a 'close' button in the same style as the 'sign' button. As users might be confused on what to do on that view. |
…ate ux of single custody assign
…waiting signature on asset page
We use the
signing-templates
branch to keep track of everything related to the templates functionality.At the time of creating this PR the branch already has the functionality for creating the templates, however we have 2 remaining issues for it:
Pending decisions: