Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signing templates #618

Draft
wants to merge 63 commits into
base: main
Choose a base branch
from
Draft

Signing templates #618

wants to merge 63 commits into from

Conversation

DonKoko
Copy link
Contributor

@DonKoko DonKoko commented Dec 20, 2023

We use the signing-templates branch to keep track of everything related to the templates functionality.
At the time of creating this PR the branch already has the functionality for creating the templates, however we have 2 remaining issues for it:

@DonKoko DonKoko marked this pull request as draft December 20, 2023 07:58
@DonKoko
Copy link
Contributor Author

DonKoko commented Apr 5, 2024

@rajdip-b okey here is the update:

  1. I have updated signing-templates with main. So you need to update your branch with signing-templates
  2. I have fixed the conflicts and added a few @TODO comments that need to be addressed before we merge this
  3. Run npm run typecheck and you will see a bunch of TS errors. That is because you have some files and routes that dont follow the new route error/response handling. Those routes need to be updated. Here are the docs: https://github.com/Shelf-nu/shelf.nu/blob/main/docs/handling-errors.md

@carlosvirreira
Copy link
Contributor

hi @rajdip-b was the update from Niko helpful?

- fixed lots of conflicts
- added lots of @todo to places where the actions/loaders need to be updated to new approach
- added lots of @ts-expect-error for places where updates are needed to follow new method
@DonKoko
Copy link
Contributor Author

DonKoko commented Apr 16, 2024

@rajdip-b Updated the PR with main.
Considering what you mentioned on discord, that you already fixed the loaders and actions, we will most likely have conflicts again as I had to touch a lot of files that had issues because of the release of Vite.
Let me know when you push your changes so I can help with fixing the conflicts.

@DonKoko
Copy link
Contributor Author

DonKoko commented May 21, 2024

Points that still need to be worked on:

  • rendering the pdf when the user tries to sign it (ive already fetched and added the pdf url in the sign component)
  • checking the overall flow of how the signing works
  • generating a receipt that jurre mentioned

DonKoko and others added 6 commits May 21, 2024 16:10
- Added migration to enable RLS for TemplateFile table
- Updated actions that werent handling async correctly
- Removed makeActive and makeInactive for template and replaced them with toggleTemplateActiveState
- Completely updated template actions and forms
- Updated some check in/check out labels
- Fixed texts for notifications for changing default and activate/deactivate template
- Updated/fixed disabled states of all template actions
fixed bugs with custody assignment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants