Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signing templates #618

Open
wants to merge 146 commits into
base: main
Choose a base branch
from
Open

Signing templates #618

wants to merge 146 commits into from

Conversation

DonKoko
Copy link
Contributor

@DonKoko DonKoko commented Dec 20, 2023

We use the signing-templates branch to keep track of everything related to the templates functionality.
At the time of creating this PR the branch already has the functionality for creating the templates, however we have 2 remaining issues for it:

Pending decisions:

  • what are the limits on custody agreements. We still need to decide and implement it on DB level
  • Assigning custody to an NRM with an agreement that doesn't require signature is kind of weird UX. What should we do?

Sorry, something went wrong.

@DonKoko DonKoko marked this pull request as draft December 20, 2023 07:58
@DonKoko
Copy link
Contributor Author

DonKoko commented Mar 19, 2025

@rockingrohit9639 yesterday we discussed the last pending point. Please find the information below on what needs to be implemented:

Limits

  • 5MB max file size for custody agreement PDF
  • Max 5 active agreements per workspace
  • Max 20 total agreements per workspace - this is a new thing but we need to do it in order to limit the max storage space used

User safety

To ensure user safety and prevent abuse from admins we have to make it so that once a template has been used once(signed or unsigned), we should not allow to change the file. To do that please disable the file field in that case with the following message: This custody agreement has already been used and signed and it's file cannot be changed anymore. If your agreement document has changed, please create a new custody agreement with your new document.

@rockingrohit9639 rockingrohit9639 requested review from rajdip-b and removed request for rajdip-b March 20, 2025 13:40
Copy link
Contributor Author

@DonKoko DonKoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Custody agreements limits should be 0 for free tier and tier_1. Only tier_2(team) can have them
  • Adding a new agreement seems to check maxCustodyAgreements instead of maxActive.... I could add a 6th one:
    Screenshot 2025-03-20 at 16 54 41
  • When custody is assigned with agreement that doesnt require signature, the link to the agreement should still be in the email.
  • Editing a file from an agreement that is used works good, but i dont see the message: This custody agreement has already been used and signed and it's file cannot be changed anymore. If your agreement document has changed, please create a new custody agreement with your new document.

Sorry, something went wrong.

@carlosvirreira
Copy link
Contributor

carlosvirreira commented Mar 25, 2025

Comments/Feedback:

Template upload area
Please add supportive text.
Screenshot 2025-03-25 at 18 14 59

Please add a column to show if the agreement is 'Ask for signature' or 'View only' (You can use the same 'pill' - as we have used on the 'default' column.
Screenshot 2025-03-25 at 18 18 32

Asset Index
If you are assigning custody via a batch action (for a SINGULAR) asset. Please emulate the same UX as we have on the asset page when performing this action. (Right now you have to open the asset page and get this done).

Advanced Asset Index
Add same icon to advanced asset index with the same hover text
Screenshot 2025-03-25 at 18 31 26

Asset Page
BUG (Although the asset is signed for ((in custody)) you can still see the 'awaiting signature' component.
Screenshot 2025-03-25 at 18 33 30

Receipts page
Add filters. Custody and Signature Status. Same style as 'asset status filters'

Receipt explorer/modal

  • Generate a PDF instead of a JPG
  • Since the asset name can change. Print the asset ID under the asset name

Signature collection screen
Please add a 'clear' that deletes any sort of signature that is on the view.
Screenshot 2025-03-25 at 18 39 41

Please make the signature font look signature-ish (https://github.com/documenso/documenso/tree/main/apps/remix/public/fonts) use Caveat.

View Only Agreement

Please add a 'close' button in the same style as the 'sign' button. As users might be confused on what to do on that view.

@carlosvirreira
Copy link
Contributor

Additional tasks:

When using Bulk Assign Custody to a Self Service OR Base user with a Sign action
After the batch action is performed please show a message.
Screenshot 2025-03-26 at 18 11 20

When using Bulk Assign Custody to a NRM with a Sign action
Screenshot 2025-03-26 at 18 12 28

When using Bulk Assign Custody to a NRM user with a View Only Agreement
Screenshot 2025-03-26 at 18 16 01

When using Bulk Assign Custody to a Self Service OR Base user with a View Only Agreement
Screenshot 2025-03-26 at 18 23 19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

None yet

4 participants