Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tag-filter): create dropdown for tag filter in advanced mode #1685

Merged
merged 6 commits into from
Mar 18, 2025

Conversation

rockingrohit9639
Copy link
Contributor

Closes - #1664

Copy link
Contributor

@DonKoko DonKoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Show All in dropdown, doesnt actually load the rest of the tags
  • If the tag you are currently filtering on, is not part of the first 12 tags loaded, its not being displayed in the field. I realized that also happens in the other enum fields and it has to do with how dynamic select and dropdown works and how we are loading the default data. I thought we already had a way to handle this in some other location, where we load the initial 12 + a set of ids of the ones that are currently being filtered. Basically every id in the params tags=containsAny%3Acm7vqkyde000zomc8ih1938vp%2Ccm7vqtvkl001tomc8xlwqpkcq should already be loaded with the initial data.

Copy link
Contributor

@DonKoko DonKoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job 🤘

@DonKoko DonKoko merged commit 1059e20 into Shelf-nu:main Mar 18, 2025
4 checks passed
@DonKoko DonKoko linked an issue Mar 18, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvement: Asset index filters - tags
2 participants