Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(booking-sorting): add SortBy on bookings index #1682

Merged
merged 7 commits into from
Mar 18, 2025

Conversation

rockingrohit9639
Copy link
Contributor

@rockingrohit9639 rockingrohit9639 commented Mar 14, 2025

Closes - #1676

Copy link
Contributor

@DonKoko DonKoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rockingrohit9639 this is a nice feature but this is completely different than #1680 which is about sorting assets within the booking page. I would say lets finish this anyways as its almost done and then separately look into #1680

@carlosvirreira
Copy link
Contributor

Pls mention me if this is released so i can inform!

…es its desc but for bookings it has to be asc because we are by default sorting by 'from'
@DonKoko DonKoko merged commit 365a178 into Shelf-nu:main Mar 18, 2025
4 checks passed
@DonKoko
Copy link
Contributor

DonKoko commented Mar 18, 2025

@carlosvirreira releasing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants