-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/enhance user import #1660
Merged
DonKoko
merged 10 commits into
Shelf-nu:main
from
rockingrohit9639:feature/enhance-user-import
Mar 17, 2025
Merged
Feature/enhance user import #1660
DonKoko
merged 10 commits into
Shelf-nu:main
from
rockingrohit9639:feature/enhance-user-import
Mar 17, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonKoko
requested changes
Feb 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Errors don't seem to be displayed correctly. For example i tried importing a user who's email is an SSO enabled domain. The error in the logs is correct:
{"level":50,"time":1740485806192,"pid":18489,"hostname":"Nikolays-MacBook.local","err":{"cause":{"cause":null,"label":"Invite","shouldBeCaptured":false,"status":400,"traceId":"o7lky0epelweqnlnx1yf3ce2","name":"ShelfError","message":"This email domain uses SSO authentication. The user needs to sign up via SSO before they can be invited.","stack":"ShelfError: This email domain uses SSO authentication. The user needs to sign up via SSO before they can be invited.
But in the view i see this:
We need to make sure the correct error message is shown.
- Same issue when the teamMemberID is invalid. It just says "Something went wrong"
- When the emails were valid, teamMembers were created even tho the import failed. This should not be the case.

DonKoko
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1615