Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/enhance user import #1660

Merged
merged 10 commits into from
Mar 17, 2025

Conversation

rockingrohit9639
Copy link
Contributor

Closes #1615

Copy link
Contributor

@DonKoko DonKoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Errors don't seem to be displayed correctly. For example i tried importing a user who's email is an SSO enabled domain. The error in the logs is correct:
{"level":50,"time":1740485806192,"pid":18489,"hostname":"Nikolays-MacBook.local","err":{"cause":{"cause":null,"label":"Invite","shouldBeCaptured":false,"status":400,"traceId":"o7lky0epelweqnlnx1yf3ce2","name":"ShelfError","message":"This email domain uses SSO authentication. The user needs to sign up via SSO before they can be invited.","stack":"ShelfError: This email domain uses SSO authentication. The user needs to sign up via SSO before they can be invited.

But in the view i see this:
Screenshot 2025-02-25 at 14 17 10
We need to make sure the correct error message is shown.

  • Same issue when the teamMemberID is invalid. It just says "Something went wrong"
  • When the emails were valid, teamMembers were created even tho the import failed. This should not be the case.
Screenshot 2025-02-25 at 14 22 46

@DonKoko DonKoko self-requested a review March 17, 2025 11:59
@DonKoko DonKoko merged commit e4b610f into Shelf-nu:main Mar 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvement: Enhance user import
2 participants