Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: subscription management UI #1657

Merged
merged 16 commits into from
Mar 17, 2025

Conversation

DonKoko
Copy link
Contributor

@DonKoko DonKoko commented Feb 24, 2025

Cases to handle (and test)

  • User is on free version
  • User with subscription with legacy pricing
  • User with a trial subscription
  • User with multiple subscriptions (active)
  • User with subscription with multiple quantity (active)
  • User with paused subscription (trial ended)
  • User with custom tier - we dont really need that anymore as we are visualizing the number of subscriptions in the subscriptions tab. - Check questions for further context.
  • User with Enterprise Tier - this stays like before because its a special case
  • What about SSO?
  • Unlimited SSO seats plan
  • User with custom plan and no subscription will see they are on free. This needs to be handled.
  • Add the option to manually disable a workspace(handling the case we had with client that had multiple workspaces and subscriptions and cancelled 2 and has 1 left)

Questions

We should have a clear way to communicate what those licenses mean. Like what does a team license with quantity 2 mean? What do 2 team licenses mean.

  • Should we show the plan description

@DonKoko DonKoko linked an issue Feb 24, 2025 that may be closed by this pull request
DonKoko and others added 7 commits February 24, 2025 16:31
- paused trial subscription
- no subscriptions
- trialing subscription
- Change how pricing table works as it no longer needs to show active plan
- Update all components related to pricing table
- re-factor how we are showing subscriptions so its based on items rather than the subscription itself
@DonKoko
Copy link
Contributor Author

DonKoko commented Feb 27, 2025

@carlosvirreira this is deployed to staging. Above is a list of things that need to be tested. You might need to create a bunch of different users to test them. I have also added some products to our test stripe that recreate real clients/users we have and their subscriptions.

@DonKoko DonKoko force-pushed the 1652-feature-subscription-management-ui branch from 5515810 to abae9ea Compare February 28, 2025 15:51
@carlosvirreira
Copy link
Contributor

User 1: Free Version ([email protected])

Observation: Signed up, picked free plan. UI shows: "You're currently using the FREE version of Shelf." Option to change subscription available.
Result: ✅ Test passes. Behavior seems correct.
Notes: The messaging is clear, and the upgrade option is present, which aligns with expectations for a free user.


User 2: Legacy Pricing Subscription ([email protected])

Observation: Activated an old subscription tier from Stripe. UI shows legacy pricing correctly.
Result: ✅ Test passes.
Notes: No issues reported. Legacy pricing is visualized as intended.


User 3: Trial Subscription ([email protected] and [email protected])

Observation:
User 3: Selected monthly billing, UI showed "LEGACY PLAN" (unexpected). Seems incorrect.

User 3a: Selected yearly billing, trial displayed correctly.

Additional confusion: On free personal workspace (https://testapp.shelf.nu/account-details/subscription), still shows "TEAM plan subscription" despite being free.

Result: ❌ Partial failure.

Issues:
Bug: Monthly trial showing "LEGACY PLAN" instead of trial status.
UI Confusion: Free personal workspace showing "TEAM plan subscription" (possibly a workspace context issue).


User 4: Multiple Active Subscriptions ([email protected])

Observation: Added Team Yearly and Plus Monthly tiers. Both display well, but:
Totals don’t match. (Not sure how much value this has).

Sidebar shows "Personal" plan, not reflecting "Plus."

Result: ✅ Mostly passes, with minor UI feedback.


User 5: Subscription with Multiple Quantity ([email protected])

Observation: Added two yearly Team subs:
One manually, one via Stripe (since users can’t have 2 workspaces directly).

UI shows both, but totals are confusing, and it’s unclear which plan applies to which workspace.

Can’t create a second team workspace without manual intervention.

Result: ❌ Partial failure.

Issues:
UI Confusion: No clear indication of which subscription applies to which workspace.
Functionality: Users can’t create a second workspace without manual changes (possible limitation or bug).


User 6: Paused Subscription (Trial Ended) (Reused User 3 and 3a)

Observation:
User 3: Post-trial simulation, UI shows "YOU'RE CURRENTLY ON THE FREE VERSION OF SHELF." No unpause option. Seems to cancel instead of pause.

User 3a: Post-trial simulation (1 day after trial), UI shows trial ended correctly.
Result: ❌ Failure for paused state.

Issues:
Bug: Trial subscriptions seem to cancel (revert to free) instead of pausing as specified in the requirements.
Missing Feature: No option to unpause or resume the subscription.


User 7: Enterprise Tier (Unnamed Email)

Observation: Created a custom Enterprise tier in Stripe. UI reflects it correctly.
Result: ✅ Test passes.
Notes: No issues. Enterprise tier visualization works as expected.


User 9: Custom Plan, No Subscription

Works well.

@DonKoko
Copy link
Contributor Author

DonKoko commented Mar 6, 2025

@carlosvirreira those issues you reported are resolved. Great finds!

@DonKoko DonKoko merged commit 3c4692a into main Mar 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Subscription management UI
2 participants