-
-
Notifications
You must be signed in to change notification settings - Fork 20
Dialog - initial work on adding dialogs #890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also commit the event as I forgot that before
- Figured out what its for
- Paper just throws a massive exception
…tch internal errors
Collaborator
|
I wonder if this is a good time to try and use more expressions/effects over the 14 section, tho I can't really think of any good patterns |
Owner
Author
Collaborator
|
True I know a few people using it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Describe your changes
This PR adds Dialogs to SkBee.
I have copied these from SkNMS, and refactored them to work with Paper's API instead of using Minecraft internals.
WIKI:
Current wiki, work in progress:
https://github.com/ShaneBeee/SkBee/wiki/Dialogs
(also copied from SkNMS wiki, needs work)
Target Minecraft Versions: MC 1.21.7+ (This is when Paper added the API)
Requirements: none
Related Issues: none
Checklist before requesting a review