Replaced: /orders -> /shipments #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loevgaard
requested changes
Mar 10, 2020
igormukhingmailcom
force-pushed
the
shipments-instead-of-orders
branch
from
a69028e
to
fae2874
Compare
loevgaard
reviewed
Mar 11, 2020
| }, | ||
| "units": [ | ||
| { | ||
| "shippable": { |
There was a problem hiding this comment.
What's the reason for this shippable array?
There was a problem hiding this comment.
This is actually product variant. But from shipments POV it called shippable
We need it (or at least link to product variant endpoint) just to know what exactly unit we have.
| { | ||
| "shippable": { | ||
| "id": @integer@, | ||
| "code": "red-mug", |
There was a problem hiding this comment.
This has the same code as the previous. We would have to ask Peter from lagersystem.dk if that is desirable
There was a problem hiding this comment.
We can put id/code and link to product variant endpoint rather than inject all info to shippable field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.