Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refatoração do método POST em carrinhos-controller #303

Merged
merged 14 commits into from
Jun 20, 2022
Merged

Refatoração do método POST em carrinhos-controller #303

merged 14 commits into from
Jun 20, 2022

Commits on Jun 19, 2022

  1. refactor(component): undefined type validation moved to a function 

    First change to refactor carrinhos-controller. Moved repeated code to a function.

re ServeRest#208
    @edumaxsantos
    edumaxsantos committed Jun 19, 2022
    Configuration menu
    Copy the full SHA
    b03dd7a View commit details
    Browse the repository at this point in the history

  2. refactor(component): extracted loop content to method 

    re ServeRest#208
    @edumaxsantos
    edumaxsantos committed Jun 19, 2022
    Configuration menu
    Copy the full SHA
    57da6fd View commit details
    Browse the repository at this point in the history

  3. refactor: wIP: Moved for loop content to function where we set precoT… 

    …otal and quantidadeTotal

re ServeRest#208
    @edumaxsantos
    edumaxsantos committed Jun 19, 2022
    Configuration menu
    Copy the full SHA
    7959519 View commit details
    Browse the repository at this point in the history

  4. refactor: removed usage of Object.assign inside post method 

    Removed usage of Object.assign inside pos method as part of the refactoring
    @edumaxsantos
    edumaxsantos committed Jun 19, 2022
    Configuration menu
    Copy the full SHA
    80746f6 View commit details
    Browse the repository at this point in the history

  5. refactor: break down a function into two. Change foor loop with index… 

    … to for of loop
    @edumaxsantos
    edumaxsantos committed Jun 19, 2022
    Configuration menu
    Copy the full SHA
    e56e2bd View commit details
    Browse the repository at this point in the history

  6. refactor: move getQuantidade and getPreco to produtos-service

    @edumaxsantos
    edumaxsantos committed Jun 19, 2022
    Configuration menu
    Copy the full SHA
    d8a3e40 View commit details
    Browse the repository at this point in the history

  7. refactor: separate calculation of quantidadeTotal and updateQuantidade() 

    When calculating quantidadeTotal we need to update quantidade to the new value. Now we have
produtosService.updateQuantidade() that will handle that for us.
    @edumaxsantos
    edumaxsantos committed Jun 19, 2022
    Configuration menu
    Copy the full SHA
    b1dafa3 View commit details
    Browse the repository at this point in the history

  8. refactor: fix repetitive code

    @edumaxsantos
    edumaxsantos committed Jun 19, 2022
    Configuration menu
    Copy the full SHA
    84069d4 View commit details
    Browse the repository at this point in the history

  9. refactor: move usuarioJaPossuiCarrinho validation to carrinhos-service

    @edumaxsantos
    edumaxsantos committed Jun 19, 2022
    Configuration menu
    Copy the full SHA
    0877a98 View commit details
    Browse the repository at this point in the history

  10. refactor: extract idUsuario into a method

    @edumaxsantos
    edumaxsantos committed Jun 19, 2022
    Configuration menu
    Copy the full SHA
    8169f18 View commit details
    Browse the repository at this point in the history

  11. refactor: separate and move precoTotal and quantidadeTotal to carrinh… 

    …os-service
    @edumaxsantos
    edumaxsantos committed Jun 19, 2022
    Configuration menu
    Copy the full SHA
    fb1b3a7 View commit details
    Browse the repository at this point in the history

  12. refactor: change name of local variable

    @edumaxsantos
    edumaxsantos committed Jun 19, 2022
    Configuration menu
    Copy the full SHA
    ee1f3ce View commit details
    Browse the repository at this point in the history

  13. refactor: move getPrecoUnitarioOuErro to produtos-service

    @edumaxsantos
    edumaxsantos committed Jun 19, 2022
    Configuration menu
    Copy the full SHA
    7fb49b6 View commit details
    Browse the repository at this point in the history

  14. refactor: change for index to for of

    @edumaxsantos
    edumaxsantos committed Jun 19, 2022
    Configuration menu
    Copy the full SHA
    670f80f View commit details
    Browse the repository at this point in the history