Refatoração do método POST em carrinhos-controller #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@edumaxsantos conseguiria atualizar a sua branch com a branch principal ( git remote add upstream [email protected]:ServeRest/ServeRest.git
git fetch upstream
git rebase upstream/trunk
git push --force-with-lease origin refactoring/controllers |
First change to refactor carrinhos-controller. Moved repeated code to a function. re ServeRest#208
…otal and quantidadeTotal re ServeRest#208
Removed usage of Object.assign inside pos method as part of the refactoring
When calculating quantidadeTotal we need to update quantidade to the new value. Now we have produtosService.updateQuantidade() that will handle that for us.
edumaxsantos
force-pushed
the
refactoring/controllers
branch
from
dc0b758
to
670f80f
Compare
|
Realizei os comandos que solicitou. Tudo certo? |
|
Acabei de revisar, ótima alteração @edumaxsantos, reduziu a complexidade da controller de carrinhos, obrigado pelo PR e desculpe pela demora em revisar. @all-contributors please add @edumaxsantos for code |
|
@all-contributors please add @edumaxsantos for code |
|
I've put up a pull request to add @edumaxsantos! 🎉 |
|
🎉 This PR is included in version 2.26.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Como discutido em #208, dei início na refatoração do método POST utilizado para cadastrar um carrinho.
How can the user experience this change?
N/A
Documentation
N/A
Related Issues
Related to #208
PR Tasks