Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix File Type References in Supported File Types Section in Tag Documentation #506

Merged
merged 2 commits into from
Jan 25, 2025

Conversation

Lepidopteran
Copy link
Contributor

@Lepidopteran Lepidopteran commented Jan 25, 2025

This fixes #505

I went an implemented the fix suggested in the said issue.

I also changed referencing lofty_attr to use path instead of published version in lofty,
If this is not wanted, I can easily revert it.

Let me know if this is good to go!

@Serial-ATA
Copy link
Owner

Looks good, thanks!

@Serial-ATA Serial-ATA merged commit 7f55f81 into Serial-ATA:main Jan 25, 2025
4 checks passed
@Lepidopteran Lepidopteran deleted the attr_tag_comment_fix branch January 26, 2025 04:20
@Serial-ATA Serial-ATA added this to the 0.22.2 milestone Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supported File Types Section Produces Invalid List of FileType References for Tag Formats in Documentation
2 participants