Meta: Add a script for building Raspberry Pi 3 and 4 images #25780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
👀 pr-needs-review
spholz
force-pushed
the
raspberry-pi-image-script
branch
2 times, most recently
from
2e917ea to
952f946
Compare
kleinesfilmroellchen
suggested changes
Mar 11, 2025
|
|
||
| DISK_SIZE=$(($(disk_usage "$SERENITY_SOURCE_DIR/Base") + $(disk_usage Root) + 512 + 300)) | ||
|
|
||
| if [ ! -d "raspberry-pi-firmware" ]; then |
There was a problem hiding this comment.
So the assumption is that we never need to update the boot directory? Can we not do a git pull (with rebase and another rm for the linux images if necessary) in the existing directory otherwise, so that you’re always up to date and upstream fixes are applied as soon as possible?
There was a problem hiding this comment.
Wouldn't a git pull --ff-only be good enough? I don't think we need to rebase here.
The framebuffer works now on both the Pi 3 and 4.
spholz
force-pushed
the
raspberry-pi-image-script
branch
from
952f946 to
8755f60
Compare
The kernel image no longer only works on Raspberry Pis, but now also on the QEMU virt machine. Rename it to Kernel.bin, so it matches the RISC-V kernel image name.
spholz
force-pushed
the
raspberry-pi-image-script
branch
from
8755f60 to
469f1b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make running serenity on Raspberry Pis easier.
Note that at least on my Raspberry Pi 3 and 4, we currently fail to initialize the SD card: