Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for NONCEs on inline scripts #799

Merged

Conversation

osnard
Copy link
Contributor

@osnard osnard commented Nov 30, 2023

@osnard
Copy link
Contributor Author

osnard commented Nov 30, 2023

Not sure if this is needed, but there are some calls to that method

/tmp/SemanticResultFormats > grep -rn "::makeVariablesScript" .
./formats/media/MediaPlayer.php:305:		SMWOutputs::requireHeadItem( $ID, SRFUtils::makeVariablesScript( $requireHeadItem, false ) );
./formats/d3/SRF_D3Chart.php:64:		SMWOutputs::requireHeadItem( $d3chartID, SRFUtils::makeVariablesScript( $requireHeadItem ) );
./formats/boilerplate/SRF_Boilerplate.php:234:		SMWOutputs::requireHeadItem( $ID, SRFUtils::makeVariablesScript( $requireHeadItem ) );
./formats/dygraphs/SRF_Dygraphs.php:209:		SMWOutputs::requireHeadItem( $chartID, SRFUtils::makeVariablesScript( $requireHeadItem ) );
./formats/timeseries/SRF_Timeseries.php:156:		SMWOutputs::requireHeadItem( $chartID, SRFUtils::makeVariablesScript( $requireHeadItem ) );
./formats/jqplot/SRF_jqPlotChart.php:61:		SMWOutputs::requireHeadItem( $chartID, SRFUtils::makeVariablesScript( $requireHeadItem ) );
./formats/jqplot/SRF_jqPlotSeries.php:327:		SMWOutputs::requireHeadItem( $chartID, SRFUtils::makeVariablesScript( $requireHeadItem ) );
./formats/sparkline/SRF_Sparkline.php:50:		SMWOutputs::requireHeadItem( $chartID, SRFUtils::makeVariablesScript( $requireHeadItem ) );
./SemanticResultFormats.utils.php:42:		SMWOutputs::requireHeadItem( 'srf.options', self::makeVariablesScript( $requireHeadItem, false ) );

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (80b0924) 40.04% compared to head (2e8e473) 40.05%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #799      +/-   ##
============================================
+ Coverage     40.04%   40.05%   +0.01%     
- Complexity     2324     2325       +1     
============================================
  Files            78       78              
  Lines          8236     8238       +2     
============================================
+ Hits           3298     3300       +2     
  Misses         4938     4938              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeroenDeDauw JeroenDeDauw merged commit b428fb3 into SemanticMediaWiki:master Nov 30, 2023
3 of 4 checks passed
@osnard osnard deleted the Add_NONCE_for_CSP_Header branch December 1, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants