Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ci.yml #798

Closed
wants to merge 1 commit into from
Closed

Update ci.yml #798

wants to merge 1 commit into from

Conversation

kizule
Copy link
Contributor

@kizule kizule commented Nov 28, 2023

Removed MediaWiki 1.40 because of:

  1. I don't remember that something related to Semantic MediaWiki has ever officially supported a non-LTS version of MediaWiki
  2. Tests are failing for MediaWiki 1.40, it's not worth fixing it as MediaWiki 1.40 is non-LTS, because of previous reasons.

Removed MediaWiki 1.40 because of:

1. I don't remember that something related to Semantic MediaWiki has ever officially supported a non-LTS version of MediaWiki
2. Tests are failing for MediaWiki 1.40, it's not worth fixing it as MediaWiki 1.40 is non-LTS, because of previous reasons.
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (80b0924) 40.04% compared to head (499158a) 40.04%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #798   +/-   ##
=========================================
  Coverage     40.04%   40.04%           
  Complexity     2324     2324           
=========================================
  Files            78       78           
  Lines          8236     8236           
=========================================
  Hits           3298     3298           
  Misses         4938     4938           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gesinn-it-gea
Copy link
Member

The question is: should we include the latest non-LTS version to indicate that there may be some open issues with a particular version? In my opinion, testing should reveal potential problems before the next LTS version is released. Unfortunately, the official MediaWiki Docker images only appear with the release, so CI could only be adapted to them very late.

What exactly bothers you about the failing CI for 1.40. The red cross?

grafik

@JeroenDeDauw
Copy link
Member

Having the failing build does make it more difficult to see if something is wrong with the PR, especially if you don't already know that MW 40 is expected to fail.

@gesinn-it-gea
Copy link
Member

I have removed 1.40 now

@gesinn-it-gea
Copy link
Member

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants