-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[py][build] Re-add Windows to CI workflows #16396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cgoldberg
merged 7 commits into
SeleniumHQ:trunk
from
cgoldberg:py-readd-windows-ci-workflows
Oct 9, 2025
Merged
[py][build] Re-add Windows to CI workflows #16396
cgoldberg
merged 7 commits into
SeleniumHQ:trunk
from
cgoldberg:py-readd-windows-ci-workflows
Oct 9, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6a25345 to
f135738
Compare
p0deje
approved these changes
Oct 9, 2025
This was referenced Oct 19, 2025
This was referenced Oct 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
🔗 Related Issues
Fixes #16390
💥 What does this PR do?
This PR adds a new GitHub Actions workflow jobs for Python:
browser-tests-windowsThis runs the Python integration tests on Windows/Chrome and Windows/Edge. The job is identical to the existing
browser-testsjob, but it includes thefsutil 8dot3name set 0command to workaround the long path name issue that Bazel has on Windows.Note: There's probably a better way to do this using a single matrix job where the command is only run when the runner is using Windows, but I couldn't figure that out.
💡 Additional Considerations
🔄 Types of changes
PR Type
Tests
Description
Add Windows CI job for browser tests
Include Windows path workaround with
fsutil 8dot3name set 0Support Chrome and Edge on Windows
Minor formatting improvements to existing commands
File Walkthrough
ci-python.yml
Add Windows CI jobs and formatting.github/workflows/ci-python.yml
browser-tests-windowsjob for Chrome, Edgefsutil 8dot3name set 0command for path issuesnew_session_tests.py
Remove extra blank linepy/test/unit/selenium/webdriver/remote/new_session_tests.py
subtyping_tests.py
Remove extra blank linepy/test/unit/selenium/webdriver/remote/subtyping_tests.py