[java] Add workaround to decode Base64 screenshots non-compliant with RFC 4648 #11179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valfirst
force-pushed
the
java-add-workaround-to-decode-base64-screenshots-non-compliant-with-rfc-4648
branch
from
ecc593f to
1d37cd0
Compare
|
Kudos, SonarCloud Quality Gate passed! |
|
Superseded by appium/java-client#1787 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding workaround for drivers non-compliant with RFC4648 (e.g. Appium) in order to keep backward compatibility. This change should be removed in future in order to meet W3C WebDriver spec requirements.
Motivation and Context
The root cause: #11107.
Fixes #11168.
Fixes appium/java-client#1783.
Types of changes
Checklist