Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotwired improvements #1449

Merged
merged 8 commits into from
Feb 23, 2025
Merged

Hotwired improvements #1449

merged 8 commits into from
Feb 23, 2025

Conversation

jbrichau
Copy link
Member

@jbrichau jbrichau commented Oct 26, 2024

  • Fix for turbolinks prefetching in Seaside (disable by default)
  • Added turbostream callback to anchors.
  • Fix bug causing state not being saved on a show: or call: in turboframes.
  • Preliminary functional tests

@jbrichau jbrichau marked this pull request as draft October 26, 2024 11:50
Copy link

codecov bot commented Oct 26, 2024

Codecov Report

Attention: Patch coverage is 5.17241% with 110 lines in your changes missing coverage. Please review.

Project coverage is 49.37%. Comparing base (0f7d6f7) to head (fb1f675).
Report is 26 commits behind head on master.

Files with missing lines Patch % Lines
...edTestComponent.class/instance/renderContentOn..st 0.00% 11 Missing ⚠️
...oFunctionalTest.class/instance/renderContentOn..st 0.00% 9 Missing ⚠️
...ctionalTest.class/instance/renderTurboScriptOn..st 0.00% 8 Missing ⚠️
...age/WAMetaElement.class/instance/turboPrefetch..st 0.00% 7 Missing ⚠️
...boTestComponent.class/instance/renderContentOn..st 0.00% 7 Missing ⚠️
...ackage/WABasicFormTag.extension/instance/turbo..st 0.00% 6 Missing ⚠️
.../WABasicFormTag.extension/instance/turboAction..st 0.00% 6 Missing ⚠️
.../WABasicFormTag.extension/instance/turboTarget..st 0.00% 6 Missing ⚠️
...reTurboFunctionalTest.class/instance/initialize.st 0.00% 6 Missing ⚠️
...chorTag.extension/instance/turboStreamCallback..st 0.00% 5 Missing ⚠️
... and 10 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1449      +/-   ##
==========================================
- Coverage   49.42%   49.37%   -0.05%     
==========================================
  Files        9073     9119      +46     
  Lines       80086    80350     +264     
==========================================
+ Hits        39582    39674      +92     
- Misses      40504    40676     +172     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbrichau jbrichau marked this pull request as ready for review February 23, 2025 13:20
Johan Brichau added 2 commits February 23, 2025 21:44
@jbrichau jbrichau merged commit d13725a into master Feb 23, 2025
17 of 24 checks passed
@jbrichau jbrichau deleted the hotwired-dev branch February 23, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant