Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

Commit

Permalink
btree: m0_btree_lrulist_set_lru_config() logs are noisy
Browse files Browse the repository at this point in the history
m0_btree_lrulist_set_lru_config() logs some statistical information
when invoked to console. Which is typically noisy for a user unlike
a developer.
e.g.
```
[root@ssc-vm-rhev4-2612 ~]# m0cp -l 'inet:tcp:10.230.241.94@22501' -H 'inet:tcp:10.230.241.94@22001' -p '<0x7000000000000001:0x0>' -P '<0x7200000000000001:0x4>' singlenode.yaml
motr[3913493]:  7020 NOTICE  [lib/uuid.c:143:m0_node_uuid_init]  Node uuid: e884506c-adb1-5015-7e92-3ad8e4873ac4
motr[3913493]:  7010 NOTICE  [be/btree.c:1904:m0_btree_lrulist_set_lru_config]  Btree LRU List Watermarks: Low - 2147483648 Mid - 3221225472 High - 4294967296
motr[3913493]:  7010 NOTICE  [be/btree.c:1906:m0_btree_lrulist_set_lru_config]  Btree LRU List trickle release: false
```

Solution:
Change log level for logs printed by m0_btree_lrulist_set_lru_config()
to M0_INFO from M0_NOTICE.

Signed-off-by: Mandar Sawant <[email protected]>
  • Loading branch information
Mandar Sawant authored and nezzzu committed Oct 13, 2022
1 parent 1981fb0 commit f88aeae
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions be/btree.c
Original file line number Diff line number Diff line change
Expand Up @@ -1899,10 +1899,10 @@ M0_INTERNAL void m0_btree_lrulist_set_lru_config(int64_t slow_lru_mem_release,
M0_ASSERT(lru_space_wm_high >= lru_space_wm_target &&
lru_space_wm_target >= lru_space_wm_low);

M0_LOG(M0_NOTICE, "Btree LRU List Watermarks: Low - %"PRIi64" Mid - "
M0_LOG(M0_INFO, "Btree LRU List Watermarks: Low - %"PRIi64" Mid - "
"%"PRIi64" High - %"PRIi64" \n", lru_space_wm_low,
lru_space_wm_target, lru_space_wm_high);
M0_LOG(M0_NOTICE, "Btree LRU List trickle release: %s \n",
M0_LOG(M0_INFO, "Btree LRU List trickle release: %s \n",
lru_trickle_release_en ? "true" : "false");
}

Expand Down
2 changes: 1 addition & 1 deletion lib/uuid.c
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ int m0_node_uuid_init(void)
rc = m0_uuid_parse(buf, uuid);
if (rc == 0) {
m0_uuid_format(uuid, buf, ARRAY_SIZE(buf));
M0_LOG(M0_NOTICE, "Node uuid: %s", (char *)buf);
M0_LOG(M0_INFO, "Node uuid: %s", (char *)buf);
} else
M0_LOG(M0_ERROR, "Unable to parse node UUID string");
} else
Expand Down

0 comments on commit f88aeae

Please sign in to comment.