Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: misbehavior in FunctionCall when calling arg multiple times #687

Merged
merged 1 commit into from
Aug 30, 2023
Merged

fix: misbehavior in FunctionCall when calling arg multiple times #687

merged 1 commit into from
Aug 30, 2023

Conversation

mohs8421
Copy link
Contributor

Bug Fixes

  • misbehaviour in FunctionCall when calling .arg() multiple times, it always overrides the previous values instead of appending them.

@mohs8421
fix: misbehavior in FunctionCall when calling arg multiple times, it …
a8c83a2 
…always overrides the previous values instead of appending them.
ikrivosheev
ikrivosheev approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@ikrivosheev ikrivosheev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mohs8421 good catch! Thank you, LGTM!

@tyt2y3 tyt2y3 merged commit 2d0d7d6 into SeaQL:master Aug 30, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikrivosheev ikrivosheev ikrivosheev approved these changes

@tyt2y3 tyt2y3 tyt2y3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mohs8421 @tyt2y3 @ikrivosheev