Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed on conflict do nothing for MySQL #680

Merged
merged 3 commits into from
Aug 22, 2023
Merged

fixed on conflict do nothing for MySQL #680

merged 3 commits into from
Aug 22, 2023

Conversation

darkmmon
Copy link
Contributor

PR Info

  • Closes
  • Dependencies:
  • Dependents:

New Features

Bug Fixes

  • fixed insert statement producing invalid statement for on_conflict do_nothing

Breaking Changes

Changes

@tyt2y3
Copy link
Member

tyt2y3 commented Aug 21, 2023

Why don't we put the logic of prepare_ignore inside prepare_insert?

@darkmmon darkmmon mentioned this pull request Aug 21, 2023
Closed
4 tasks
@tyt2y3
Copy link
Member

tyt2y3 commented Aug 21, 2023 •
edited
Loading

Please add some test cases, in both tests/mysql and as inline doc tests.

tyt2y3
tyt2y3 reviewed Aug 22, 2023
View reviewed changes
src/query/on_conflict.rs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@tyt2y3 tyt2y3 changed the base branch from master to on_conflict-do-nothing-fixup August 22, 2023 08:24
@tyt2y3 tyt2y3 merged commit a213d3b into SeaQL:on_conflict-do-nothing-fixup Aug 22, 2023
20 checks passed
@tyt2y3
Copy link
Member

tyt2y3 commented Aug 22, 2023

Not yet on master

@tyt2y3 tyt2y3 mentioned this pull request Aug 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyt2y3 tyt2y3 tyt2y3 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darkmmon @tyt2y3