Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rust toolchain file #648

Closed
wants to merge 0 commits into from
Closed

Conversation

EstebanBorai
Copy link
Contributor

@EstebanBorai EstebanBorai commented Jun 17, 2023

Provides a Toolchain File to control Rust version to use,
currently the file points to Nightly Latest.

This facilitates contributors when running commands like

cargo +nightly fmt

This is an update from: #643

@billy1624
Copy link
Member

Thanks!! @EstebanBorai Interesting stuff. Basically, this config will force cargo fmt and cargo clippy to execute the respective component in nightly version.

REF: https://rust-lang.github.io/rustup/overrides.html#the-toolchain-file

@EstebanBorai
Copy link
Contributor Author

Thanks!! @EstebanBorai Interesting stuff. Basically, this config will force cargo fmt and cargo clippy to execute the respective component in nightly version.

REF: https://rust-lang.github.io/rustup/overrides.html#the-toolchain-file

Yes!!

@EstebanBorai
Copy link
Contributor Author

Thanks!! @EstebanBorai Interesting stuff. Basically, this config will force cargo fmt and cargo clippy to execute the respective component in nightly version.

REF: https://rust-lang.github.io/rustup/overrides.html#the-toolchain-file

@billy1624 can we merge this?

Copy link
Member

@ikrivosheev ikrivosheev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EstebanBorai thank you! LGTM!

@billy1624 is it ok for you?

@EstebanBorai
Copy link
Contributor Author

@billy1624 can we merge this?

@EstebanBorai
Copy link
Contributor Author

Oh! I think I closed this by accident! Im sorry!
Do you guys think it would be useful to have? I could reopen if thats the case!

@EstebanBorai
Copy link
Contributor Author

Reopening here: #698 @ikrivosheev! I think this is helpful and improves DevEx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants