Bind array values in SQLx PostgreSQL driver

[billy1624]

PR Info

• Continue Implemented 'Array' type for Postgres. #205
• Fixing 67a8ffb

[tyt2y3]

Ah, so we still have to clone the values :(
But yea, it's so elaborate

[billy1624]

Ah, so we still have to clone the values :( But yea, it's so elaborate

I can't think of a better way of doing it... given the defined Value::array

[tyt2y3]

It would be slightly better if we introduce a separate function that takes ownership of Values

[billy1624]

It would be slightly better if we introduce a separate function that takes ownership of Values

When binding the value onto SQLx query? Currently, it's taking value as reference.

[tyt2y3]

I think this will need to updated after merging #267
It seems like a considerable maintenance cost IMO

[itsbalamurali]

@billy1624 @tyt2y3 since #267 is merged. Can this be rebased and merged?

[emmiegit]

Exciting! Glad to see array work progress.

[ikrivosheev]

@billy1624 Do you need help with this PR?

[emmiegit]

Is there anything blocking this PR from being merged?

[tyt2y3]

Apart from the merge conflict, I think we need to think of a less verbose approach at supporting this.
The problem is when we add a new type variant to Value, it seems like that a lot has to be changed, and we have no compile-time check / CI that can catch those.
Basically a maintainability problem.

[kudlatyamroth]

maybe it is better to implement this in that form, and in future refactor it?
i think that many ppl needs this functionality

[tyt2y3]

I think sea-query-binder offers a better starting point than sea-query-driver, we should probably build on top of that

[Sytten]

Indeed I am in need of it so anything I can do to help let me know.

[billy1624]

Hey @Sytten @tyt2y3, I think we could dump this PR and start working on this feature from master, i.e. based on sea-query-binder.

[billy1624]

Would you like to take on this? @Sytten

[Sytten]

Yeah will do

[billy1624]

Thanks! @Sytten
Do let me know if you need help :D