Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update setting search path in postgres #2241

Merged
merged 2 commits into from
Jun 19, 2024
Merged

fix: update setting search path in postgres #2241

merged 2 commits into from
Jun 19, 2024

Conversation

jdrouet
Copy link
Contributor

@jdrouet jdrouet commented May 28, 2024

Bug Fixes

When doing ops.set_schema_search_path("first_schema,public"), the initial code only took into consideration the first_schema because of the quotes in '{schema}'. Removing the quotes fixes this.

jdrouet and others added 2 commits May 28, 2024 10:00
@jdrouet
fix: update setting search path in postgres
7b2fa01 
When using multiple schemas in search path for postgres, using quoted string breaks the ability to use multiple schemas.
Removing the quotes fixes it.
@billy1624
Add test cases
b1d7c46
billy1624
billy1624 approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! @jdrouet for spotting this.

Related discussions: https://dba.stackexchange.com/a/175116

I adding a test case to validate it's actually working as expected :)

@billy1624 billy1624 requested a review from tyt2y3 May 30, 2024 10:20
@billy1624
Copy link
Member

Hey @tyt2y3, ready for review!

@jdrouet
Copy link
Contributor Author

jdrouet commented Jun 14, 2024

👋 gentle bump

@billy1624 billy1624 merged commit 055dbf0 into SeaQL:master Jun 19, 2024
33 checks passed
tyt2y3
tyt2y3 reviewed Jun 19, 2024
View reviewed changes
Copy link
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@github-actions GitHub Actions
Copy link

🎉 Released In 1.0.0-rc.6 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 4, 2024

🎉 Released In 1.0.0 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyt2y3 tyt2y3 tyt2y3 left review comments

@billy1624 billy1624 billy1624 approved these changes

Assignees

@jdrouet jdrouet

@billy1624 billy1624

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdrouet @billy1624 @tyt2y3