-
-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement "Nest" for DerivePartialModel
and From QueryResult
#1716
Conversation
Thank you for the contribution again! You might be a stronger derive macro guru than I am. |
Crate syn with its major version update usually contain one or more break changes ,I cannot guarantee there is no conflict. I think I can wait for that PR merged ,then I will handle the conflict in this PR. |
Two things:
|
2 things but 3 points :) The emoji is 'gitmoji' I like using those emoji to mark each commit action. I'll add examples in the near future. |
# Conflicts: # sea-orm-macros/src/derives/from_query_result.rs
(Sorry for coming in from the side..) Is there a specific reason this was closed? We were looking forward to using this - if required, I can also take a shot at implementing the nesting bit. |
Why this pr closed? I had never close it? |
However, the code is a bit old, I need time to read and refactor it |
update to newest code
@Goodjooy Hi again、I am really sorry for coming in from the side, but since we kind of desperately need this feature, I decided to do a separate implementation in #2179 . I honestly only care about this feature landing as quickly as possible, so I would not mind if you take my code and update your PR, if you prefer that path instead of my PR superseding yours. CC: @tyt2y3 |
Maintaining your own modified version of the nest feature might be a more ideal way right now. Adding features usually needs a minor version update which might waiting a bit longer than bug fixing. Not to mention that the core maintainers now are busy in releasing the 1.0 version right now. |
Hey, thank you for everyone's involvement. I think the only things missing from this PR are some tests and a bit of doc example? |
there was a better one #2179 that this pr can be close |
PR Info
DerivePartialModel
andFromQueryResult
#1715New Features
FromQueryResult
supportflatten
DerivePartialModel
supportflatten
Changes
FromQueryResult
has attributessea_orm