feat: add method find_both_related()

[ProbablyClem]

PR Info

• Closes find_also_related() with non null relation, or using inner join, should not return Option

New Features

• new selector SelectBoth in which the return type is Vec<(E::Model, F::Model)>
• a new method fn select_both<F>(mut self, _: F) -> SelectBoth<E, F> on Select
• new method fn find_both_related()<R>(self, r: R) -> SelectBoth<E, R>

[Pascualex]

I'm not familiar with the internals of SeaORM, but this looks like a very direct and clean conversion of the implementation for select_also.

Wouldn't it make sense to also add a find_both_related method? Thank you for your contribution.

[ProbablyClem]

I'm not familiar with the internals of SeaORM, but this looks like a very direct and clean conversion of the implementation for select_also.

Wouldn't it make sense to also add a find_both_related method? Thank you for your contribution.

Thanks @Pascualex
Yeah, I do like that name, as it matches the find_xxx_related as talked in the issue.
Do you think I should rename the inner_join_and_select or create a new one @tyt2y3 ?

[ProbablyClem]

I renamed it for now, as I think find_both_related is a better name.
I can still go back to inner_join_and_select if wanted just let me know

[tyt2y3]

Thank you for the contribution, find_both_related is a good name.

[Bolognafingers]

Shame this wasn't merged