feat: write scripts for building a Pi 4 (64-bit) WebView #2216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nicomiguelino
commented
Feb 26, 2025
Contributor
Author
There was a problem hiding this comment.
Refactor common attributes.
Contributor
Author
There was a problem hiding this comment.
We can maybe create a script that generates custom Dockerfiles based on the given platform (e.g., pi1, pi2, pi3, pi4, pi4-64, pi5, etc.).
Comment on lines
17
to
19
| QRect screenGeometry = QGuiApplication::primaryScreen()->geometry(); | ||
| setGeometry(screenGeometry); | ||
| showFullScreen(); |
Contributor
Author
There was a problem hiding this comment.
Make use of macros, which gets resolved before compilation.
nicomiguelino
commented
Dec 22, 2025
| You should now be able to invoke a run executing either of the following commands: | ||
|
|
||
| ```bash | ||
| $ docker compose exec builder-pi5 /webview/build_webview.sh |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| $ docker compose exec builder-pi5 /webview/build_webview.sh | |
| $ docker compose exec builder-pi5 /scripts/build_webview.sh |
nicomiguelino
commented
Dec 22, 2025
| ```bash | ||
| $ docker compose exec builder-pi5 /webview/build_webview.sh | ||
| # or | ||
| $ docker compose exec builder-pi4-64 /webview/build_webview.sh |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| $ docker compose exec builder-pi4-64 /webview/build_webview.sh | |
| $ docker compose exec builder-pi4-64 /scripts/build_webview.sh |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist