checkers: proper pkg/obj check for flagName (go-critic#786)

The main problem came from the flagName trying to check method calls while it should only handle function calls. Fixes go-critic#784. Signed-off-by: Iskander Sharipov <[email protected]>
ScrambleShell · Feb 1, 2019 · d82b576 · d82b576
1 parent d19dbf1
commit d82b576
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/checkers/flagName_checker.go b/checkers/flagName_checker.go
@@ -3,6 +3,7 @@ package checkers
 import (
 	"go/ast"
 	"go/constant"
+	"go/types"
 	"strings"
 
 	"github.com/go-lintpack/lintpack"
@@ -30,13 +31,14 @@ type flagNameChecker struct {
 
 func (c *flagNameChecker) VisitExpr(expr ast.Expr) {
 	call := astcast.ToCallExpr(expr)
-	sym := astcast.ToIdent(astcast.ToSelectorExpr(call.Fun).Sel)
-	obj := c.ctx.TypesInfo.ObjectOf(sym)
-	if obj == nil {
+	calledExpr := astcast.ToSelectorExpr(call.Fun)
+	obj, ok := c.ctx.TypesInfo.ObjectOf(astcast.ToIdent(calledExpr.X)).(*types.PkgName)
+	if !ok {
 		return
 	}
-	pkg := obj.Pkg()
-	if !isStdlibPkg(pkg) || pkg.Name() != "flag" {
+	sym := calledExpr.Sel
+	pkg := obj.Imported()
+	if !isStdlibPkg(pkg) || obj.Name() != "flag" {
 		return
 	}
 

diff --git a/checkers/testdata/flagName/negative_tests.go b/checkers/testdata/flagName/negative_tests.go
@@ -4,6 +4,12 @@ import (
 	"flag"
 )
 
+func methodCall() {
+	// See #784.
+	var getter flag.Getter
+	_ = getter.String()
+}
+
 func noWhitespace() {
 	_ = flag.Bool("name", false, "")
 	_ = flag.Duration("name", 0, "")