checkers: add math.Max and math.Min to dupArg (go-critic#792)

Signed-off-by: Iskander Sharipov <[email protected]>
ScrambleShell · Feb 2, 2019 · cbe095d · cbe095d
1 parent 34c1dc8
commit cbe095d
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/checkers/dupArg_checker.go b/checkers/dupArg_checker.go
@@ -48,6 +48,9 @@ func init() {
 		c.matchers = map[string]func(*ast.CallExpr) bool{
 			"copy": m["(x, x, ...)"],
 
+			"math.Max": m["(x, x, ...)"],
+			"math.Min": m["(x, x, ...)"],
+
 			"reflect.Copy":      m["(x, x, ...)"],
 			"reflect.DeepEqual": m["(x, x, ...)"],
 

diff --git a/checkers/testdata/dupArg/positive_tests.go b/checkers/testdata/dupArg/positive_tests.go
@@ -5,6 +5,7 @@ import (
 	"go/types"
 	"image"
 	"image/draw"
+	"math"
 	"reflect"
 	"strings"
 )
@@ -91,4 +92,10 @@ func duplicatedArgs() {
 		/*! suspicious duplicated args in `draw.Draw(dstImg, area, dstImg, point, op)` */
 		draw.Draw(dstImg, area, dstImg, point, op)
 	}
+
+	var x float64
+	/*! suspicious duplicated args in `math.Max(x, x)` */
+	_ = math.Max(x, x)
+	/*! suspicious duplicated args in `math.Min(x, x)` */
+	_ = math.Min(x, x)
 }