checkers: suggest buf.Reset() instead of buf.Truncate(0) (go-critic#811)

Signed-off-by: Iskander Sharipov <[email protected]>
ScrambleShell · Feb 28, 2019 · 447088f · 447088f
1 parent 94a6b5c
commit 447088f
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 0 deletions.
diff --git a/checkers/testdata/wrapperFunc/negative_tests.go b/checkers/testdata/wrapperFunc/negative_tests.go
@@ -10,6 +10,11 @@ import (
 func appliedSuggestions(s string, b []byte) {
 	var wg sync.WaitGroup
 	wg.Done()
+	wg.Add(1)
+
+	var buf bytes.Buffer
+	buf.Reset()
+	buf.Truncate(1)
 
 	strings.ToTitle(s)
 	strings.ReplaceAll(s, "a", "b")

diff --git a/checkers/testdata/wrapperFunc/positive_tests.go b/checkers/testdata/wrapperFunc/positive_tests.go
@@ -13,6 +13,10 @@ func f(s string, b []byte) {
 	/*! use WaitGroup.Done method in `wg.Add(-1)` */
 	wg.Add(-1)
 
+	var buf bytes.Buffer
+	/*! use Buffer.Reset method in `buf.Truncate(0)` */
+	buf.Truncate(0)
+
 	/*! use strings.ToTitle method in `strings.Map(unicode.ToTitle, s)` */
 	strings.Map(unicode.ToTitle, s)
 

diff --git a/checkers/wrapperFunc_checker.go b/checkers/wrapperFunc_checker.go
@@ -39,6 +39,10 @@ func init() {
 			"sync.WaitGroup.Add => WaitGroup.Done": {
 				{0, "-1"},
 			},
+
+			"bytes.Buffer.Truncate => Buffer.Reset": {
+				{0, "0"},
+			},
 		}
 
 		pkgPatterns := map[string][]arg{