Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move tephi to src/tephi #166

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

move tephi to src/tephi #166

wants to merge 4 commits into from

Conversation

ESadek-MO
Copy link
Contributor

part of #164

@rcomer
Copy link
Member

rcomer commented Nov 4, 2024

Do we know why repo review advises the code to be under src? A quick check of the big four scientific python packages show three of them (numpy, pandas, scipy) have their package at the top of the repo like tephi currently does. matplotlib has its C and C++ code under src but its python code under lib.

@ESadek-MO
Copy link
Contributor Author

It's not repo review that's asking for this, so much as following Iris' conventions as far as I know! Repo review wants tests to be in root, but the rest of it is just standardising. If this proves too difficult, I don't mind putting this on the backburner.

@bjlittle
Copy link
Member

bjlittle commented Nov 5, 2024

@rcomer See https://packaging.python.org/en/latest/discussions/src-layout-vs-flat-layout/ for some pros and cons

Personally I prefer the src-layout, but that's just me 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants