Update test_Saver__ugrid.py #6017
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct comment, since after #6004 the behaviour, and the testcase changed but the comment did not !
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6017 +/- ##
=======================================
Coverage 89.75% 89.75%
=======================================
Files 90 90
Lines 22951 22951
Branches 5027 5027
=======================================
Hits 20600 20600
Misses 1620 1620
Partials 731 731 ☔ View full report in Codecov by Sentry. |
ESadek-MO
requested changes
Jun 27, 2024
| @@ -178,7 +178,7 @@ def mesh_location_size(mesh, location): | |||
|
|
|||
|
|
|||
| # A simple "standard" test mesh for multiple uses, which we can use for cubes | |||
| # that *share* a mesh (since we don't support mesh equality). | |||
| # that ** a mesh (since we don't support mesh equality). | |||
There was a problem hiding this comment.
Not sure what this is meant to mean?
"... we can use for cubes that ** a mesh..."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct comment, since after #6004 the behaviour, and the testcase changed but the comment did not !
@ESadek-MO tiny fix : hope this makes sense to you.